refactor!(client): replace the optional RequestConfig arg to Client::send() with a with_request_config() builder method
#4443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4443 +/- ##
==========================================
- Coverage 85.42% 85.42% -0.01%
==========================================
Files 283 283
Lines 31556 31566 +10
==========================================
+ Hits 26958 26966 +8
- Misses 4598 4600 +2 ☔ View full report in Codecov by Sentry. |
bnjbvr
force-pushed
the
bnjbvr/remove-config-from-clientsend
branch
from
8260578 to
c7b87f3
Compare
poljar
requested changes
Dec 19, 2024
poljar
force-pushed
the
bnjbvr/remove-config-from-clientsend
branch
from
c7b87f3 to
20af6ea
Compare
|
To prevent bitrot on this during the holidays, I took the freedom to implement the change myself, I also added a changelog entry and reworded the now obsolete commit message. |
poljar
approved these changes
Dec 20, 2024
poljar
force-pushed
the
bnjbvr/remove-config-from-clientsend
branch
from
20af6ea to
f17bef9
Compare
…ilder method Instead of `Client::send(request, request_config)`, consumers can now do `Client::send(request).with_request_config(request_config)`.
jplatte
reviewed
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of
Client::send(request, request_config), consumers can now doClient::send(request).with_request_config(request_config). The parameter is stillOptional to avoid messy patterns, when therequest_configis anOptionpassed from the caller.The messy pattern would look like this, if
with_request_configtook aRequestConfigand not anOption<RequestConfig>: